docs(api): set manifestUri as deprecated #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdtsw
requested review from
lburgazzoli and
VaishnaviHire
and removed request for
ajaypratap003 and
gzaronikas
zdtsw
changed the title
|
looks good, but I'm not in the list of reviewers :) |
thought i dont need bother you for the docs change :D |
5 tasks
5 tasks
ykaliuta
approved these changes
Oct 13, 2024
ykaliuta
approved these changes
Oct 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1137 +/- ##
==========================================
- Coverage 18.72% 18.59% -0.14%
==========================================
Files 154 157 +3
Lines 10282 10500 +218
==========================================
+ Hits 1925 1952 +27
- Misses 8145 8332 +187
- Partials 212 216 +4 ☔ View full report in Codecov by Sentry. |
zdtsw
force-pushed
the
chore_82
branch
3 times, most recently
from
1849500 to
0e4ec9a
Compare
- we do not use this for devFlag in DSCI any more - it was used when we still have odh-manifests repo - if use would set devFlags, it should be done in DSC on component base - keep logic still in code but only set warning on API Signed-off-by: Wen Zhou <[email protected]>
ykaliuta
approved these changes
Jan 13, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 3843dcd
into
opendatahub-io:main
10 checks passed
MarianMacik
pushed a commit
to MarianMacik/opendatahub-operator
that referenced
this pull request
Jan 22, 2025
…flux/component-updates/odh-model-controller-v2-17 chore(deps): update odh-model-controller-v2-17 to 4e08ddf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria